Re: [Xen-devel] [PATCH] common: make sure symbols-dummy.o gets rebuilt when needed

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Nov 22, 2018 at 03:47:41AM -0700, Jan Beulich wrote:
> The per-arch top level make files don't record any dependencies for the
> file, so its mere existence is enough for make to consider it up-to-
> date. As of ab3e5f5ff9 ("xsplice, symbols: Implement fast symbol names
> -> virtual addresses lookup") the file, however, depends on the
> FAST_SYMBOL_LOOKUP config option, which may change between incremental
> re-builds.
> 
> Use the $(extra-y) machinery to get the file built without an extra
> recursion step into common/, but instead right when the other things in
> that directory get built.

AFAICT extra-y machinery was broken before this patch. It might be worth
calling that out here.

> 
> Take the opportunity and also make the gendep invocation cover both
> $(obj-bin-y) and $(extra-y), even if this is not directly related here.
> I should have included them right away in 8b6ef9c152 ("compat: enforce
> distinguishable file names in symbol table").
> 
> Reported-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> --- a/xen/arch/arm/Makefile
> +++ b/xen/arch/arm/Makefile
> @@ -100,9 +100,6 @@ prelink.o: $(ALL_OBJS)
>       $(LD) $(LDFLAGS) -r -o $@ $^
>  endif
>  
> -$(BASEDIR)/common/symbols-dummy.o:
> -     $(MAKE) -f $(BASEDIR)/Rules.mk -C $(BASEDIR)/common symbols-dummy.o
> -
>  $(TARGET)-syms: prelink.o xen.lds $(BASEDIR)/common/symbols-dummy.o

As discussed on IRC direct dependencies on symbols-dummy.o should be
deleted.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel