Re: [Xen-devel] [PATCH 4/4] automation: add qemu smoke test

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Nov 20, 2018 at 10:41:07AM -0600, Doug Goldstein wrote:
> On Mon, Nov 19, 2018 at 09:31:02PM +0000, Wei Liu wrote:
> > This patch introduces a new test stage into the pipeline and provides
> > a simple QEMU based smoke test.
> > 
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > ---
> >  .gitlab-ci.yml                          | 19 +++++++++++++++++++
> >  automation/scripts/qemu-smoke-x86-64.sh | 23 +++++++++++++++++++++++
> >  2 files changed, 42 insertions(+)
> >  create mode 100755 automation/scripts/qemu-smoke-x86-64.sh
> > 
> > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > index d11459b117..b9ccba6ab2 100644
> > --- a/.gitlab-ci.yml
> > +++ b/.gitlab-ci.yml
> > @@ -1,5 +1,6 @@
> >  stages:
> >    - build
> > +  - test
> >  
> >  .build-tmpl: &build
> >    stage: build
> > @@ -379,3 +380,21 @@ debian-unstable-gcc-debug-arm64-randconfig:
> >    variables:
> >      CONTAINER: debian:unstable-arm64v8
> >      RANDCONFIG: y
> > +
> > +
> > +# Test jobs
> > +qemu-smoke-x86-64:
> > +  stage: test
> > +  image: registry.gitlab.com/xen-project/xen/${CONTAINER}
> > +  variables:
> > +    CONTAINER: debian:stretch
> > +  script:
> > +    - ./automation/scripts/qemu-smoke-x86-64.sh 2>&1 | tee 
> > qemu-smoke-x86-64.log
> 
> Do you want to capture this log in the artifacts below too?

Good catch. I will add it to the list.

> 
> > +  artifacts:
> > +    paths:
> > +      - smoke.serial
> > +    when: always
> > +  dependencies:
> > +    - debian-stretch-gcc-debug
> > +  tags:
> > +    - x86_64
> 
> Just one quick question. If you do that can be fixed up at commit time
> as well so I have no problem saying:
> 
> Acked-by: Doug Goldstein <cardoe@xxxxxxxxxx>

Thank you.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel