Re: [Xen-devel] [PATCH v2] x86: fix efi.lds dependency generation

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Nov 19, 2018 at 03:45:23AM -0700, Jan Beulich wrote:
> >>> On 19.11.18 at 11:25, <wei.liu2@xxxxxxxxxx> wrote:
> > --- a/xen/arch/x86/Makefile
> > +++ b/xen/arch/x86/Makefile
> > @@ -234,12 +234,12 @@ $(BASEDIR)/include/asm-x86/asm-macros.h: asm-macros.i 
> > Makefile
> >  
> >  xen.lds: xen.lds.S
> >     $(CC) -P -E -Ui386 $(filter-out -Wa$(comma)%,$(AFLAGS)) -o $@ $<
> > -   sed -e 's/xen\.lds\.o:/xen\.lds:/g' <.xen.lds.d >.xen.lds.d.new
> > +   sed -e 's/.*\.lds\.o:/$(@F):/g' <.$(@F).d >.$(@F).d.new
> >     mv -f .xen.lds.d.new .xen.lds.d
> 
> Hmm, okay, this can be relaxed, but I'm not sure it's needed. Anyway
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Thanks.

> albeit if you already bring both rules into closer sync, adjusting the last
> line above at the same time would have been nice.

Alright. I can fold that in as well.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel