Re: [Xen-devel] [PATCH] x86: fix efi.lds dependency generation

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 18.11.18 at 14:14, <wei.liu2@xxxxxxxxxx> wrote:
> RANDCONFIG builds discover efi.lds is not updated when autogenerated
> headers are updated.
> 
> Upon inspection, the generated .d file contains xen.lds.o as target,
> not the once thought efi.lds.o. That's because gcc disregards the
> output object name specified by -o when generating dependency, so the
> sed invocation has no effect.

Arguably this is a gcc bug, which I'd expect them to fix at some point.
Hence I'd prefer ...

> --- a/xen/arch/x86/Makefile
> +++ b/xen/arch/x86/Makefile
> @@ -239,7 +239,7 @@ xen.lds: xen.lds.S
>  
>  efi.lds: xen.lds.S
>       $(CC) -P -E -Ui386 -DEFI $(filter-out -Wa$(comma)%,$(AFLAGS)) -o $@ $<
> -     sed -e 's/efi\.lds\.o:/efi\.lds:/g' <.$(@F).d >.$(@F).d.new
> +     sed -e 's/xen\.lds\.o:/efi\.lds:/g' <.$(@F).d >.$(@F).d.new

... if this allowed for both the observed and the supposedly
correct variants. Perhaps simply allowing for any *.lds.o as
a target would be best?

Also while at it would you mind stripping the bogus /
superfluous (afaict) backslash escaping the . in the
replacement string, at which point $@ would imo be better
to use there (or $(@F) to be consistent with the input and
output redirection)? (I realize I must have been the one to
not do it this way in the first place.)

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel