[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH RFC 0/6] mm/kdump: allow to exclude pages that are logically offline
- To: Nadav Amit <namit@xxxxxxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, linux-mm <linux-mm@xxxxxxxxx>
- From: Julien Freche <jfreche@xxxxxxxxxx>
- Date: Thu, 15 Nov 2018 01:42:30 +0000
- Accept-language: en-US
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=jfreche@xxxxxxxxxx;
- Cc: Michal Hocko <mhocko@xxxxxxxx>, "open list:DOCUMENTATION" <linux-doc@xxxxxxxxxxxxxxx>, Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>, Pavel Machek <pavel@xxxxxx>, Alexander Duyck <alexander.h.duyck@xxxxxxxxxxxxxxx>, "K. Y. Srinivasan" <kys@xxxxxxxxxxxxx>, Omar Sandoval <osandov@xxxxxx>, Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Stephen Hemminger <sthemmin@xxxxxxxxxxxxx>, Baoquan He <bhe@xxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Pavel Tatashin <pasha.tatashin@xxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, David Rientjes <rientjes@xxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Dave Young <dyoung@xxxxxxxxxx>, Alexey Dobriyan <adobriyan@xxxxxxxxx>, Len Brown <len.brown@xxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, "linux-pm@xxxxxxxxxxxxxxx" <linux-pm@xxxxxxxxxxxxxxx>, Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>, Mike Rapoport <rppt@xxxxxxxxxxxxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Naoya Horiguchi <n-horiguchi@xxxxxxxxxxxxx>, Vlastimil Babka <vbabka@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Kairui Song <kasong@xxxxxxxxxx>, Christian Hansen <chansen3@xxxxxxxxx>, "Rafael J. Wysocki" <rjw@xxxxxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, Miles Chen <miles.chen@xxxxxxxxxxxx>, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>, "devel@xxxxxxxxxxxxxxxxxxxxxx" <devel@xxxxxxxxxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, "Kirill A. Shutemov" <kirill.shutemov@xxxxxxxxxxxxxxx>
- Delivery-date: Thu, 15 Nov 2018 06:08:31 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
- Thread-index: AQHUfG14AtUUXm8lq0WDadIpB+L9naVP5EIAgAAJ9AD//5vDAA==
- Thread-topic: [PATCH RFC 0/6] mm/kdump: allow to exclude pages that are logically offline
>On 11/14/18, 3:41 PM, "Nadav Amit" <namit@xxxxxxxxxx> wrote:
>>From: David Hildenbrand
>>Sent: November 14, 2018 at 11:05:38 PM GMT
>> Subject: Re: [PATCH RFC 0/6] mm/kdump: allow to exclude pages that are
>> logically offline
>>
>>
>> Can you share if something like this is also desired for vmware's
>> implementation? (I tagged this as RFC to get some more feedback)
>>
>> It should in theory be as simple as adding a handful of
>> _SetPageOffline()/_ClearPageOffline() at the right spots.
>
> Thanks, I was just suspecting it is personal ;-)
>
> I would obviously prefer that your changes would be done on top of those
> that were skipped. This patch-set sounds very reasonable to me, but I prefer
> that Julien (cc’d) would also give his opinion.
I think this is desirable for VMware's implementation also. You are right,
dumping data that is not relevant is a waste :-)
I haven't heard of any panic/issue due to this but that's still a good
optimization.
Nadav or I could help to test that on ESX if required.
Regards,
--
Julien Freche
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
