Re: [Xen-devel] [PATCH v5 11/15] libxl_dm: Pre-open QMP socket for QEMU

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Tue, Oct 16, 2018 at 03:11:03PM +0100, Ian Jackson wrote:
> Anthony PERARD writes ("[PATCH v5 11/15] libxl_dm: Pre-open QMP socket for 
> QEMU"):
> >      ret = libxl__build_device_model_args(gc, "stubdom-dm", guest_domid,
> >                                           guest_config, &args, NULL,
> > -                                         d_state, NULL);
> > +                                         d_state, NULL, NULL);
> 
> Did you consider adding dm_monitor_fd to d_state ?

No, I didn't, I'm not sur what can go into d_state. But that seems
better that adding an argument to many function prototypes.

On the other hand, I would need to make sure that dm_monitor_fd have a
proper initial value (-1) when needed.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel