Re: [Xen-devel] [PATCH] x86/badpage: Fix badpage->order overflow

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.11.18 at 15:42, <andrew.cooper3@xxxxxxxxxx> wrote:
> For order 32 or more, the shift will truncate.  Spotted by Coverity.

I find this pretty absurd. What about order 64 or more? Are you
suggesting you expect 16Tb or larger bad page ranges?

> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Anyway, as I don't mind the adjustment
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

But I'm sure you're aware we have many more examples of
1U (or even plain 1) getting shifted by an order value.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel