Re: [Xen-devel] [PATCH v6 26/26] xen/arm: split domain_build.c

[Julien Grall <julien.grall@xxxxxxx>]

Hi Stefano,

On 02/11/2018 23:45, Stefano Stabellini wrote:
> domain_build.c is too large.
>
> Move all the ACPI specific device tree generating functions from
> domain_build.c to acpi/domain_build.c.
>
> Signed-off-by: Stefano Stabellini <stefanos@xxxxxxxxxx>
>
> ---
>
> Changes in v6:
> - fix license
>
> Changes in v4:
> - rename acpi_dt_build to domain_build.c
> - add copyright header
> - remove useless #include
> - remove acpi_dt_build.h, add domain_build.h
> ---
>   xen/arch/arm/acpi/Makefile         |   1 +
>   xen/arch/arm/acpi/domain_build.c   | 591 +++++++++++++++++++++++++++++++++++++
>   xen/arch/arm/domain_build.c        | 585 +-----------------------------------
>   xen/include/asm-arm/domain_build.h |  31 ++
>   4 files changed, 628 insertions(+), 580 deletions(-)
>   create mode 100644 xen/arch/arm/acpi/domain_build.c
>   create mode 100644 xen/include/asm-arm/domain_build.h
>
> diff --git a/xen/arch/arm/acpi/Makefile b/xen/arch/arm/acpi/Makefile
> index 23963f8..94ae249 100644
> --- a/xen/arch/arm/acpi/Makefile
> +++ b/xen/arch/arm/acpi/Makefile
> @@ -1,2 +1,3 @@
>   obj-y += lib.o
> +obj-y += domain_build.o
One minor comment. It would be good if we check all symbols in this file belongs 
to init. Can you use domain_build.init.o here?
With that:

Acked-by: Julien Grall <julien.grall@xxxxxxx>

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel