[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v6 08/26] xen/arm: probe domU kernels and initrds



Hi Stefano,

On 02/11/2018 23:45, Stefano Stabellini wrote:
-    info->initrd_bootmodule = boot_module_find_by_kind(BOOTMOD_RAMDISK);
+    printk("Loading Dom%d kernel from boot module @ %"PRIpaddr"\n",
+           info->d->domain_id, info->kernel_bootmodule->start);

NIT: You probably want to use the new %pd format. This will allow you to print a domain more consistently and also drop ->domain_id :).

The rest of the code looks good:

Acked-by: Julien Grall <julien.grall@xxxxxxx>

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.