Re: [Xen-devel] [PATCH v3 4/4] xen: use SYMBOL everywhere

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.11.18 at 23:27, <sstabellini@xxxxxxxxxx> wrote:
> On Thu, 8 Nov 2018, Jan Beulich wrote:
>> >>> On 06.11.18 at 23:05, <sstabellini@xxxxxxxxxx> wrote:
>> > ---
>> >  xen/arch/arm/alternative.c          |  7 ++--
>> >  xen/arch/arm/arm32/livepatch.c      |  2 +-
>> >  xen/arch/arm/arm64/livepatch.c      |  2 +-
>> >  xen/arch/arm/domain_build.c         |  2 +-
>> >  xen/arch/arm/livepatch.c            |  6 +--
>> >  xen/arch/arm/mm.c                   | 17 ++++----
>> >  xen/arch/arm/setup.c                |  8 ++--
>> >  xen/arch/x86/setup.c                | 79 
>> > +++++++++++++++++++------------------
>> >  xen/arch/x86/tboot.c                | 12 +++---
>> >  xen/arch/x86/x86_64/machine_kexec.c |  4 +-
>> >  xen/drivers/vpci/vpci.c             |  7 +++-
>> >  xen/include/asm-arm/grant_table.h   |  3 +-
>> >  xen/include/asm-arm/mm.h            |  4 +-
>> >  xen/include/asm-x86/mm.h            |  4 +-
>> >  xen/include/xen/kernel.h            | 24 +++++------
>> >  15 files changed, 97 insertions(+), 84 deletions(-)
>> 
>> Just like for v2: Did you really check you caught them all? The vPCI
>> ones I had pointed at back then were only an example. Another
>> example now is xen/common/kernel.c:_cmdline_parse().
> 
> It is difficult to catch them all. Any suggestion on how to make sure
> there are no leftover (other than waiting for the next QAVerify scan)?

First an foremost go through all symbols generated by linker scripts.
Most if not all will bound either side of a section.

> Maybe, I should just remove the word "everywhere" from the commit
> message?

That would help too, together with enumerating what patterns
you've looked for.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel