Re: [Xen-devel] [PATCH] x86/amd: don't set pv_post_outb_hook when !CONFIG_PV

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.11.18 at 15:58, <wei.liu2@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/cpu/amd.c
> +++ b/xen/arch/x86/cpu/amd.c
> @@ -631,7 +631,9 @@ static void init_amd(struct cpuinfo_x86 *c)
>       case 0xf ... 0x17:
>               disable_c1e(NULL);
>               if (acpi_smi_cmd && (acpi_enable_value | acpi_disable_value)) {
> +#ifdef CONFIG_PV
>                       pv_post_outb_hook = amd_check_disable_c1e;
> +#endif
>                       amd_acpi_c1e_quirk = true;
>               }
>               break;

Hmm, I would have hoped for this to get properly cleaned up,
as outlined in that other thread, if you already touch it. Anyway,
I see you've got the necessary acks, so the subsequent
cleanup patch will just have to delete two more lines.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel