[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/1] tools/ocaml: make type of Xsraw.sync more precise

Christian Lindig writes ("Re: [Xen-devel] [PATCH 1/1] tools/ocaml: make type of 
Xsraw.sync more precise"):
> > On 30 Oct 2018, at 16:50, Ian Jackson <ian.jackson@xxxxxxxxxx> wrote:
> > I'm not much of an ocaml programmer but this seems like it has no
> > overall functional change ?
> > 
> > I take it that ignore is the trivial function with type ('a -> unit).
> That is correct. Except that types now reflect more accurately what is 
> happening. I discovered this when compiling the libraries with another build 
> system and the compiler complained about this.

Great.  How useful of it.

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

FTR I find it helpful to mention in the commit message when a commit
has no functional change.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.