Re: [Xen-devel] [PATCH v5 08/25] xen/arm: probe domU kernels and initrds

[Julien Grall <julien.grall@xxxxxxx>]

Hi Stefano,

On 23/10/2018 03:02, Stefano Stabellini wrote:
> Find addresses, sizes on device tree from kernel_probe.
> Find the cmdline from the bootcmdlines array.
>
> Introduce a new boot_module_find_by_addr_and_kind function to match not
> just on boot module kind, but also by address so that we can support
> multiple domains.
>
> Introduce a boot_cmdline_find_by_name function to find the right struct
> cmdline based on the device tree node name of the "xen,domain"
> compatible node.
>
> Set command line for dom0 too for consistency.
I was expecting you to remove the assignment in construct_dom0 to avoid the 
duplication.
[...]

> diff --git a/xen/arch/arm/kernel.c b/xen/arch/arm/kernel.c
> index da8410e..d56f776 100644
> --- a/xen/arch/arm/kernel.c
> +++ b/xen/arch/arm/kernel.c
> @@ -421,22 +421,72 @@ static int __init kernel_zimage32_probe(struct 
> kernel_info *info,
>       return 0;
>   }
>   
> -int __init kernel_probe(struct kernel_info *info)
> +int __init kernel_probe(struct kernel_info *info,
> +                        const struct dt_device_node *domain)
>   {
> -    struct bootmodule *mod = boot_module_find_by_kind(BOOTMOD_KERNEL);
> +    struct bootmodule *mod = NULL;
> +    struct bootcmdline *cmd = NULL;
> +    struct dt_device_node *node;
> +    u64 kernel_addr, initrd_addr, size;
>       int rc;
>   
> +    /* domain is NULL only for the hardware_domain */
NIT: No need to the _.

The rest of the code looks good to me.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel