Re: [Xen-devel] [PATCH v2 07/16] x86: put XEN_DOMCTL_{set, get}_address_size under CONFIG_PV

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 19.10.18 at 16:28, <wei.liu2@xxxxxxxxxx> wrote:
> They are useful to PV only.

Considering there was no is_{hvm,pv}_...() check so far, I think
you need to extend this a little plus ...

> --- a/xen/arch/x86/domctl.c
> +++ b/xen/arch/x86/domctl.c
> @@ -608,6 +608,7 @@ long arch_do_domctl(
>              copyback = true;
>          break;
>  
> +#ifdef CONFIG_PV
>      case XEN_DOMCTL_set_address_size:
>          if ( ((domctl->u.address_size.size == 64) && !d->arch.is_32bit_pv) ||
>               ((domctl->u.address_size.size == 32) && d->arch.is_32bit_pv) )
> @@ -623,6 +624,7 @@ long arch_do_domctl(
>                                                                
> BITS_PER_LONG;
>          copyback = true;
>          break;
> +#endif

... add such a check so that similar behavior will result with PV
enabled and disabled (error codes may differ, but success vs
error ought to match).

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel