[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 01/22] xen/arm: traps: Constify show_registers parameters

On 10/24/18 3:03 PM, Andrii Anisov wrote:
Hello Julien,


On 18.10.18 16:20, Julien Grall wrote:
show_registers helpers are not meant to modify any parameters.
So constify them.

Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
   xen/arch/arm/traps.c            | 14 +++++++-------
   xen/include/asm-arm/processor.h |  2 +-
   2 files changed, 8 insertions(+), 8 deletions(-)
The file xen/arch/arm/traps.c has a bunch of show functions except for
registers. For stack, trace, etc. So maybe constify their parameters
right away?

Good idea. I will update the series.


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.