[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 02/18] loader/linux: support passing rsdp address via boot params


  • To: Daniel Kiper <daniel.kiper@xxxxxxxxxx>
  • From: Juergen Gross <jgross@xxxxxxxx>
  • Date: Thu, 18 Oct 2018 16:36:28 +0200
  • Autocrypt: addr=jgross@xxxxxxxx; prefer-encrypt=mutual; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNHkp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmRlPsLAeQQTAQIAIwUCU4xw6wIbAwcL CQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJELDendYovxMvi4UH/Ri+OXlObzqMANruTd4N zmVBAZgx1VW6jLc8JZjQuJPSsd/a+bNr3BZeLV6lu4Pf1Yl2Log129EX1KWYiFFvPbIiq5M5 kOXTO8Eas4CaScCvAZ9jCMQCgK3pFqYgirwTgfwnPtxFxO/F3ZcS8jovza5khkSKL9JGq8Nk czDTruQ/oy0WUHdUr9uwEfiD9yPFOGqp4S6cISuzBMvaAiC5YGdUGXuPZKXLpnGSjkZswUzY d9BVSitRL5ldsQCg6GhDoEAeIhUC4SQnT9SOWkoDOSFRXZ+7+WIBGLiWMd+yKDdRG5RyP/8f 3tgGiB6cyuYfPDRGsELGjUaTUq3H2xZgIPfOwE0EU4xwFgEIAMsx+gDjgzAY4H1hPVXgoLK8 B93sTQFN9oC6tsb46VpxyLPfJ3T1A6Z6MVkLoCejKTJ3K9MUsBZhxIJ0hIyvzwI6aYJsnOew cCiCN7FeKJ/oA1RSUemPGUcIJwQuZlTOiY0OcQ5PFkV5YxMUX1F/aTYXROXgTmSaw0aC1Jpo w7Ss1mg4SIP/tR88/d1+HwkJDVW1RSxC1PWzGizwRv8eauImGdpNnseneO2BNWRXTJumAWDD pYxpGSsGHXuZXTPZqOOZpsHtInFyi5KRHSFyk2Xigzvh3b9WqhbgHHHE4PUVw0I5sIQt8hJq 5nH5dPqz4ITtCL9zjiJsExHuHKN3NZsAEQEAAcLAXwQYAQIACQUCU4xwFgIbDAAKCRCw3p3W KL8TL0P4B/9YWver5uD/y/m0KScK2f3Z3mXJhME23vGBbMNlfwbr+meDMrJZ950CuWWnQ+d+ Ahe0w1X7e3wuLVODzjcReQ/v7b4JD3wwHxe+88tgB9byc0NXzlPJWBaWV01yB2/uefVKryAf AHYEd0gCRhx7eESgNBe3+YqWAQawunMlycsqKa09dBDL1PFRosF708ic9346GLHRc6Vj5SRA UTHnQqLetIOXZm3a2eQ1gpQK9MmruO86Vo93p39bS1mqnLLspVrL4rhoyhsOyh0Hd28QCzpJ wKeHTd0MAWAirmewHXWPco8p1Wg+V+5xfZzuQY0f4tQxvOpXpt4gQ1817GQ5/Ed/wsDtBBgB CAAgFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAlrd8NACGwIAgQkQsN6d1ii/Ey92IAQZFggA HRYhBFMtsHpB9jjzHji4HoBcYbtP2GO+BQJa3fDQAAoJEIBcYbtP2GO+TYsA/30H/0V6cr/W V+J/FCayg6uNtm3MJLo4rE+o4sdpjjsGAQCooqffpgA+luTT13YZNV62hAnCLKXH9n3+ZAgJ RtAyDWk1B/0SMDVs1wxufMkKC3Q/1D3BYIvBlrTVKdBYXPxngcRoqV2J77lscEvkLNUGsu/z W2pf7+P3mWWlrPMJdlbax00vevyBeqtqNKjHstHatgMZ2W0CFC4hJ3YEetuRBURYPiGzuJXU pAd7a7BdsqWC4o+GTm5tnGrCyD+4gfDSpkOT53S/GNO07YkPkm/8J4OBoFfgSaCnQ1izwgJQ jIpcG2fPCI2/hxf2oqXPYbKr1v4Z1wthmoyUgGN0LPTIm+B5vdY82wI5qe9uN6UOGyTH2B3p hRQUWqCwu2sqkI3LLbTdrnyDZaixT2T0f4tyF5Lfs+Ha8xVMhIyzNb1byDI5FKCb
  • Cc: hans@xxxxxxxxxxx, grub-devel@xxxxxxx, phcoder@xxxxxxxxx, xen-devel@xxxxxxxxxxxxx
  • Delivery-date: Thu, 18 Oct 2018 14:36:32 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Openpgp: preference=signencrypt

On 18/10/2018 16:30, Daniel Kiper wrote:
> On Thu, Oct 18, 2018 at 04:18:26PM +0200, Juergen Gross wrote:
>> On 18/10/2018 16:13, Daniel Kiper wrote:
>>> On Tue, Oct 09, 2018 at 01:03:01PM +0200, Juergen Gross wrote:
>>>> Xen PVH guests will have the RSDP at an arbitrary address. Support that
>>>> by passing the RSDP address via the boot parameters to Linux.
>>>>
>>>> The new protocol version 2.14 requires to set version to 0x8000 ored
>>>> with the actually use protocol version (the minimum of the kernel
>>>> supplied protocol version and the grub2 supported protocol version)
>>>> if 2.14 or higher are in effect.
>>>>
>>>> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
>>>> ---
>>>> V2: add oring 0x8000 to version field
>>>> ---
>>>>  grub-core/loader/i386/linux.c | 9 +++++++++
>>>>  include/grub/i386/linux.h     | 5 ++++-
>>>>  2 files changed, 13 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/grub-core/loader/i386/linux.c b/grub-core/loader/i386/linux.c
>>>> index 4eab55a2d..f96309476 100644
>>>> --- a/grub-core/loader/i386/linux.c
>>>> +++ b/grub-core/loader/i386/linux.c
>>>> @@ -35,6 +35,7 @@
>>>>  #include <grub/i18n.h>
>>>>  #include <grub/lib/cmdline.h>
>>>>  #include <grub/linux.h>
>>>> +#include <grub/machine/kernel.h>
>>>
>>> Probably this change belongs to another patch.
>>
>> I don't think so.
> 
> You do not add anything to this header here and out of the blue you
> include it in this file. So, why it is needed here?

Ah, now I see your problem.

machine/kernel.h will be the header which eventually defines
GRUB_KERNEL_USE_RSDP_ADDR.

> 
>>>>  GRUB_MOD_LICENSE ("GPLv3+");
>>>>
>>>> @@ -750,6 +751,14 @@ grub_cmd_linux (grub_command_t cmd __attribute__ 
>>>> ((unused)),
>>>>        prot_init_space = page_align (prot_size) * 3;
>>>>      }
>>>>
>>>> +#ifdef GRUB_KERNEL_USE_RSDP_ADDR
>>>> +  if (grub_le_to_cpu16 (lh.version) >= 0x020e)
>>>> +    lh.acpi_rsdp_addr = grub_le_to_cpu64 (grub_rsdp_addr);
>>>> +#endif
>>>
>>> It seems to me that this belongs to patch #8. Does not it?
>>
>> No, it is a generic new interface.
>>
>> It will be used by PVH first, but can be used in other environments,
>> too.
> 
> I do not like this much but if you want me to get it you have to put
> a blurb in the commit message why this is not enabled here. And when
> it will be enabled...

Okay, will do.


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.