Re: [Xen-devel] [PATCH] iommu: fix arm build after e9be34be5

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Xen-devel [mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxxx] On Behalf
> Of Wei Liu
> Sent: 09 October 2018 19:58
> To: xen-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>; Jan Beulich <jbeulich@xxxxxxxx>; Roger
> Pau Monne <roger.pau@xxxxxxxxxx>
> Subject: [Xen-devel] [PATCH] iommu: fix arm build after e9be34be5
> 
> The function iommu_share_p2m_table is used by both ARM and x86 but
> hap_enabled macro is x86 only. Put the ASSERT under CONFIG_X86.

Would it be unreasonable to make hap_enabled() common and define it to true for 
ARM?

  Paul

> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
>  xen/drivers/passthrough/iommu.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/xen/drivers/passthrough/iommu.c
> b/xen/drivers/passthrough/iommu.c
> index e03de6e3ab..8b438ae4bc 100644
> --- a/xen/drivers/passthrough/iommu.c
> +++ b/xen/drivers/passthrough/iommu.c
> @@ -505,7 +505,9 @@ int iommu_do_domctl(
> 
>  void iommu_share_p2m_table(struct domain* d)
>  {
> +#ifdef CONFIG_X86
>      ASSERT(hap_enabled(d));
> +#endif
>      /*
>       * iommu_use_hap_pt(d) cannot be used here because during domain
>       * construction need_iommu(d) will always return false here.
> --
> 2.11.0
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel