Re: [Xen-devel] [PATCH] x86/vtd: fix iommu_share_p2m_table

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Mon, Oct 08, 2018 at 12:37:39PM +0200, Roger Pau Monné wrote:
> On Mon, Oct 08, 2018 at 04:33:04AM -0600, Jan Beulich wrote:
> > >>> On 08.10.18 at 12:14, <roger.pau@xxxxxxxxxx> wrote:
> > > --- a/xen/drivers/passthrough/iommu.c
> > > +++ b/xen/drivers/passthrough/iommu.c
> > > @@ -505,7 +505,7 @@ int iommu_do_domctl(
> > >  
> > >  void iommu_share_p2m_tableiommu_share_p2m_table(struct domain* d)
> > >  {
> > > -    if ( iommu_use_hap_pt(d) )
> > > +    if ( iommu_enabled && hap_enabled(d) && iommu_hap_pt_share )
> > 
> > Considering the only caller, the hap_enabled() part is (and was) not
> > needed here.
> 
> Would you like me to remove it in this patch?

I've converted it to an ASSERT instead of just removing it.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel