Re: [Xen-devel] [PATCH v3] xen:arm: Populate arm64 image header

[Stewart Hildebrand <Stewart.Hildebrand@xxxxxxxxxxxxxxx>]

On 11/09/2018 17:48, Amit Singh Tomar wrote:
> diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
> index d63734f..ef87b5c 100644
> --- a/xen/arch/arm/arm64/head.S
> +++ b/xen/arch/arm/arm64/head.S
> @@ -120,8 +127,8 @@ efi_head:
>           add     x13, x18, #0x16
>           b       real_start           /* branch to kernel start */
>           .quad   0                    /* Image load offset from start of RAM 
> */
> -        .quad   0                    /* reserved */
> -        .quad   0                    /* reserved */
> +        .quad   _end - start         /* Effective size of kernel image, 
> little-endian */
> +        .quad   __HEAD_FLAGS         /* Informative flags, little-endian */
>           .quad   0                    /* reserved */
>           .quad   0                    /* reserved */
>           .quad   0                    /* reserved */

Since 17bd254a xen:arm: Populate arm64 image header, qemu-system-aarch64 has 
not been too happy about booting Xen.

Trying to launch qemu-system-aarch64 gives the following error:
rom: requested regions overlap (rom bootloader. free=0x00000000400d0150, 
addr=0x0000000040000000)
qemu-system-aarch64: rom check and register reset failed

Reverting 17bd254a allowed it to boot again. Alternatively, setting the image 
offset to some value allowed it to boot again.
 
diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
index ef87b5c..8879c77 100644
--- a/xen/arch/arm/arm64/head.S
+++ b/xen/arch/arm/arm64/head.S
@@ -126,7 +126,7 @@ efi_head:
          */
         add     x13, x18, #0x16
         b       real_start           /* branch to kernel start */
-        .quad   0                    /* Image load offset from start of RAM */
+        .quad   0x00080000           /* Image load offset from start of RAM */
         .quad   _end - start         /* Effective size of kernel image, 
little-endian */
         .quad   __HEAD_FLAGS         /* Informative flags, little-endian */
         .quad   0                    /* reserved */

I'm not sure if this is a fault of qemu, or if Xen should put some value in the 
image load offset field?

For reference, I'm using the following script to build and launch qemu+Xen 
https://gist.github.com/stewdk/110f43e0cc1d905fc6ed4c7e10d8d35e
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel