Re: [Xen-devel] [PATCH] p2m: move p2m-common.h inclusion point

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 05.10.18 at 12:21, <Paul.Durrant@xxxxxxxxxx> wrote:
>>  -----Original Message-----
>> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
>> Sent: 05 October 2018 11:14
>> To: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
>> Cc: Julien Grall <julien.grall@xxxxxxx>; Andrew Cooper
>> <Andrew.Cooper3@xxxxxxxxxx>; Paul Durrant <Paul.Durrant@xxxxxxxxxx>; Wei
>> Liu <wei.liu2@xxxxxxxxxx>; George Dunlap <George.Dunlap@xxxxxxxxxx>; Ian
>> Jackson <Ian.Jackson@xxxxxxxxxx>; Stefano Stabellini
>> <sstabellini@xxxxxxxxxx>; Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>;
>> Tim (Xen.org) <tim@xxxxxxx>
>> Subject: [PATCH] p2m: move p2m-common.h inclusion point
>> 
>> The header is (hence its name) supposed to be a helper for the per-arch
>> p2m.h files. It was never supposed to be included directly, and for the
>> purpose of putting common function declarations into the common header
>> it is more helpful if things like p2m_t are already available at the
>> inclusion point.
>> 
>> Take the opportunity and also ditch a duplicate public/memory.h from the
>> ARM header.
>> 
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> I suppose you could now drop the 'forward enum declaration' part of my patch 
> now that it is no longer forwards (depending on which is committed first of 
> course).

Yeah, that's the purpose of the patch. I have a respective note in
here, for the case that yours goes in further (I mean to see whether
I can commit more of your series later today, but for now I'm fighting
build problems after Wei's CONFIG_HVM disable series).

> Reviewed-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

Thanks.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel