[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v14 4/9] iommu: don't domain_crash() inside iommu_map/unmap_page()

>>> On 04.10.18 at 18:36, <Paul.Durrant@xxxxxxxxxx> wrote:
> I still think an implicit domain_crash() doesn't really belong in something 
> that looks like a straightforward wrapper around a per-implementation jump 
> table. How about iommu_map/unmap_may_crash() instead to highlight the 
> semantic?

If anything then the other way around, i.e. iommu_unmap_no_crash(),
such that only callers who explicitly mean to deal with the crashing
themselves would use the otherwise insecure variant.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.