Re: [Xen-devel] [[PATCH v3] 4/4] xen/arm: Replace call_smc with arm_smccc_smc

[Julien Grall <julien.grall@xxxxxxx>]

Hi Stefano,

On 10/01/2018 09:52 PM, Stefano Stabellini wrote:
> On Mon, 1 Oct 2018, Stefano Stabellini wrote:
> > On Mon, 1 Oct 2018, Julien Grall wrote:
> > > call_smc is a subset of arm_smccc_smc. Rather than having 2 methods to
> > > do SMCCC call, replace all call to the former by the later.
> > >
> > > Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
> > Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> >
> > (you might want to make sure the double [[ is removed on commit.)
> Hey Julien,
>
> I was going to commit the series, but I am getting a build error:
>
> psci.c: In function 'call_psci_cpu_on':
> psci.c:45:40: error: request for member 'a0' in something not a structure or 
> union
>   #define PSCI_RET(res)   ((int32_t)(res).a0)
>                                          ^
> psci.c:54:12: note: in expansion of macro 'PSCI_RET'
>       return PSCI_RET(res.a0);
>              ^
> psci.c:55:1: error: control reaches end of non-void function 
> [-Werror=return-type]
>   }
I already mentioned this error in reply to the patch [1] and suggested 
it could be fixed on commit...
Cheers,

[1] <9e0160ad-853c-6efa-1a04-15f801ef06da@xxxxxxx>

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel