Re: [Xen-devel] [PATCH 1/6] xen/vsprintf: Introduce %*pb[l] for printing bitmaps

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 25.09.18 at 15:06, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 07/09/18 16:14, Jan Beulich wrote:
>>> Irrespective of whether you think it is ambiguous or not, I don't view
>>> this as a good enough (potential) issue to diverge.
>>>
>>> Furthermore, (and more likely to sway your opinion), N1570 indicates
>>> that the 'l' length modifier is only applicable for the diouxXcs
>>> conversion specifiers, and both Clang and GCC enforce this with -Wformat.
>>>
>>> andrewcoop@andrewcoop:/local/xen.git/xen$ clang-6.0 -Wall -Werror -Wextra 
>>> foo.c -o foo.o
>>> foo.c:7:22: error: length modifier 'l' results in undefined behavior or no 
>>> effect with 'p' conversion specifier [-Werror,-Wformat]
>>>     printf("Testing %lpd\n", ptr);
>>>                     ~^~
>>> 1 error generated.
>> Yeah, I started to be concerned of this happening after I had sent
>> the reply. Given this I guess we have no (good) choice besides going
>> the suffix route.
> 
> So can I take this as at least an ack?  Currently this series is stalled.

With at least the bug addressed that I had pointed out in the first
reply, and preferably with the int -> unsigned int conversion done
where suitable, yes.

For later patches, where applicable, I insist on using cpumask_bits()
outside of cpumask.h, though.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel