Re: [Xen-devel] [PATCH] automation: introduce a new variable to control container user

[Doug Goldstein <cardoe@xxxxxxxxxx>]

On Mon, Sep 24, 2018 at 05:18:29PM +0100, Wei Liu wrote:
> Sometimes it is handy to create a container and play as root with its
> setup manually.
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
>  automation/scripts/containerize | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/automation/scripts/containerize b/automation/scripts/containerize
> index bf9af589a8..ea3c7378aa 100755
> --- a/automation/scripts/containerize
> +++ b/automation/scripts/containerize
> @@ -23,6 +23,12 @@ case "_${CONTAINER}" in
>      _stretch|_) CONTAINER="${BASE}/debian:stretch" ;;
>  esac
>  
> +# Use this variable to control whehter root should be used
> +case "_${CONTAINER_ROOT}" in
> +    _1)   userarg= ;;
> +    _0|_) userarg="-u $(id -u)" ;;
> +esac

How would you feel about CONTAINER_UID0 instead? I just fear that "ROOT"
has quite a few meanings. e.g top of the filesystem? The working dir
inside of the container?

Mind documenting this in automation/build/README.md ? I should likely
move part of this file that describes the variables up a directory.

--
Doug

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel