Re: [Xen-devel] [PATCH 00/12] add per-domain and per-cpupool generic parameters

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Sep 19, 2018 at 07:58:50PM +0200, Juergen Gross wrote:
> 
> Did you look into the patches, especially patch 10? The parameters set
> are all stored in domain config via libxl__arch_domain_save_config().

No, I didn't.

I think the general idea of what you do in patch 10 should work. However
I want to comment on the implementation.

It appears that the implementation in patch 10 concatenates the new
settings to the old ones. It is not very nice imo.

If for the life time of the domain you set X times the same parameter
you get a string of foo=bar1 foo=bar2 in the saved config file.

There is probably a simple solution: make the parameter list in IDL a
key value list. You then update the list accordingly.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel