[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/6] xen/sched: Use %*pb[l] instead of cpumask_scn{, list}printf()



On Fri, 2018-09-07 at 15:42 +0100, George Dunlap wrote:
> On 09/06/2018 01:08 PM, Andrew Cooper wrote:
> > This removes all use of keyhandler_scratch as a bounce-buffer for
> > the rendered
> > string.  In some cases, collapse combine adjacent printk()'s which
> > are writing
> > parts of the same line.
> > 
> > No functional change.
> > 
> > Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> 
> Acked-by: George Dunlap <george.dunlap@xxxxxxxxxx>
>
Acked-by: Dario Faggioli <dfaggioli@xxxxxxxx>

As it's a clear improvement wrt current state of things, IMO.

I agree with Jan that having to remember to always pass nr_cpu_ids is
unideal.

I'm fine with adding trying to find a solution to this to my todo-list
(although, not on the top of it, probably :-D ).

Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Software Engineer @ SUSE https://www.suse.com/

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.