Re: [Xen-devel] [PATCH 3/7] xen/hvm: Rename d->arch.hvm_domain to d->arch.hvm

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 28.08.18 at 19:39, <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/hvm/vmsi.c
> +++ b/xen/arch/x86/hvm/vmsi.c
> @@ -173,7 +173,7 @@ static DEFINE_RCU_READ_LOCK(msixtbl_rcu_lock);
>   */
>  static bool msixtbl_initialised(const struct domain *d)
>  {
> -    return !!d->arch.hvm_domain.msixtbl_list.next;
> +    return !!d->arch.hvm.msixtbl_list.next;

How about dropping the !! here at the same time?

> @@ -1643,7 +1643,7 @@ void vmx_vcpu_flush_pml_buffer(struct vcpu *v)
>  
>  bool_t vmx_domain_pml_enabled(const struct domain *d)
>  {
> -    return !!(d->arch.hvm_domain.vmx.status & VMX_DOMAIN_PML_ENABLED);
> +    return !!(d->arch.hvm.vmx.status & VMX_DOMAIN_PML_ENABLED);
>  }

And here.

> @@ -112,7 +112,7 @@ static void vpic_update_int_output(struct hvm_hw_vpic 
> *vpic)
>          if ( vpic->is_master )
>          {
>              /* Master INT line is connected in Virtual Wire Mode. */
> -            struct vcpu *v = vpic_domain(vpic)->arch.hvm_domain.i8259_target;
> +            struct vcpu *v = vpic_domain(vpic)->arch.hvm.i8259_target;
>              if ( v != NULL )

And adding a blank line here?


In any event
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel