Re: [Xen-devel] [PATCH] xen/grant: Mute gcc warning in steal_linear_address()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 30.08.18 at 06:06, <zhenzhong.duan@xxxxxxxxxx> wrote:
> Move reference of ol1e ahead or else we see below warning.
> 
> cc1: warnings being treated as errors
> grant_table.c: In function 'replace_grant_pv_mapping':
> grant_table.c:142: warning: 'ol1e.l1' may be used uninitialized in this 
> function
> 
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@xxxxxxxxxx>

I'm fine with the change, but going forward please be more specific
with your descriptions: Whether or not warnings get emitted for a
certain piece of code often highly depends on compiler version. Let
us know which version you've run this into with. For the record, I'm
building on a wide range of gcc versions every once in a while, and
I've not come across this warning so far (or else I would have sent
a patch). The really old versions (4.1.x for example) can't really be
used anymore for certain other reasons anyway, and I think it's
about time we at least raise the bar a little (also for binutils, which
iirc was the actual problem with here, using a version matching in
original release time with gcc 4.1.x).

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel