Re: [Xen-devel] [PATCH] x86/mm: re-arrange get_page_from_l<N>e() vs pv_l1tf_check_l<N>e

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 29.08.18 at 16:42, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 29/08/18 14:26, Jan Beulich wrote:
>>>>> On 29.08.18 at 15:16, <andrew.cooper3@xxxxxxxxxx> wrote:
>>> On 17/08/18 07:42, Jan Beulich wrote:
>>>> Restore symmetry between get_page_from_l<N>e(): pv_l1tf_check_l<N>e is
>>>> uniformly invoked from outside of them.
>>> I'm not sure what symmetry you are referring to.
>> Just look at the current state: get_page_from_l[234]e() call
>> pv_l1tf_check_l[234]e(), but get_page_from_l1e() in the
>> same situation. Instead alloc_l1_table() does.
> 
> I'm afraid that I can't even parse this, but I think I've got the point.
> 
> IMO, it would be clearer for the commit message to read "is now now
> uniformly invoked".

Oh, yes, the "now" should have been there.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel