[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 3/6] xen/arm: add RCAR2 kconfig



(Switching to my Arm e-mail)

Hi,

On 24/08/18 20:31, Stefano Stabellini wrote:
On Fri, 24 Aug 2018, Julien Grall wrote:
Hi,

On 24/08/18 00:33, Stefano Stabellini wrote:
Add a kconfig option for Renesas Rcar2 platforms.

Signed-off-by: Stefano Stabellini <stefanos@xxxxxxxxxx>
Reviewed-by: Andrii Anisov <andrii_anisov@xxxxxxxx>
CC: iurii.konovalenko@xxxxxxxxxxxxxxx
---
   xen/arch/arm/platforms/Kconfig  | 11 +++++++++++
   xen/arch/arm/platforms/Makefile |  2 +-
   2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig
index a43c938..e54825a 100644
--- a/xen/arch/arm/platforms/Kconfig
+++ b/xen/arch/arm/platforms/Kconfig
@@ -53,6 +53,13 @@ config SUNXI
        Enable all the required drivers for Allwinnder sunxi platforms,
        including Pine64, OrangePi, CubieBoard, etc.
   +config RCAR2
+       bool "Renesas R-Car Gen2"
+       depends on ARM_32
+       select HAS_SCIF
+       ---help---
+       Enable all the required drivers for Renesas R-Car Gen2.

Technically the UART is not required. By selecting it, you give no way to the
user to remove it.

I don't know of a way to select the UART driver by default, which is the
desired configuration for the majority, while still allowing users to
remove it if they want to.

You can't do this directly with Kconfig. Linux is solving the problem by introducing "config fragment" and using scripts/kconfig/merge_config.sh to merge the fragments.

The scripts exists on Xen in xen/xen/tools/kconfig/. So if you provide
a fragment for tiny and R-Car, you could merge both in a single one.

This would also give the freedom for the user to tailor a bit more his .config.

Cheers,



--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.