[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 31/34] xen: refuse to create HVM guests when !CONFIG_HVM



>>> On 17.08.18 at 17:12, <wei.liu2@xxxxxxxxxx> wrote:
> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -318,8 +318,14 @@ struct domain *domain_create(domid_t domid,
>      if ( !is_idle_domain(d) )
>      {
>          if ( config->flags & XEN_DOMCTL_CDF_hvm_guest )
> +        {
> +#if CONFIG_HVM
>              d->guest_type = guest_type_hvm;
> -        else
> +#else
> +            err = -EINVAL;
> +            goto fail;
> +#endif
> +        } else
>              d->guest_type = guest_type_pv;

Would you mind doing the CONFIG_PV case of this as well, which
would then probably also make more apparent that the "else"
above belongs on its own line? Of course once again part of the
final look of this section depends on what ARM folks want to do
with regard to CONFIG_HVM.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.