Re: [Xen-devel] [PATCH 19/34] x86: check HVM before trying to get ioreq server

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.08.18 at 17:12, <wei.liu2@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/mm.c
> +++ b/xen/arch/x86/mm.c
> @@ -4382,6 +4382,10 @@ int arch_acquire_resource(struct domain *d, unsigned 
> int type,
>          unsigned int i;
>  
>          rc = -EINVAL;
> +        if ( !is_hvm_domain(d) )
> +            break;
> +
> +        rc = -EINVAL;
>          if ( id != (unsigned int)ioservid )
>              break;

I think the entire case block was better wrapped in an #ifdef, so that
with no HVM support execution would fall into default: instead.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel