Re: [Xen-devel] [PATCH 15/34] x86/nestedhvm: make it build with !CONFIG_HVM

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.08.18 at 17:12, <wei.liu2@xxxxxxxxxx> wrote:

The title isn't very consistent within itself: Nested-HVM code is certainly
not to be built without CONFIG_HVM.

> @@ -70,7 +74,18 @@ unsigned long *nestedhvm_vcpu_iomap_get(bool_t ioport_80, 
> bool_t ioport_ed);
>  
>  void nestedhvm_vmcx_flushtlb(struct p2m_domain *p2m);
>  
> -bool_t nestedhvm_is_n2(struct vcpu *v);
> +static inline bool nestedhvm_is_n2(struct vcpu *v)

I'm tempted to suggest the parameter could be constified, but it
looks like this would require some const additions elsewhere first.

> +{
> +    if ( !nestedhvm_enabled(v->domain) ||
> +        nestedhvm_vmswitch_in_progress(v) ||
> +        !nestedhvm_paging_mode_hap(v) )
> +        return false;
> +
> +    if ( nestedhvm_vcpu_in_guestmode(v) )
> +        return true;
> +
> +    return false;

Can the last four lines be a single return statement please? With
that
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel