Re: [Xen-devel] [PATCH 11/34] xen/pt: io.c contains HVM only code

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.08.18 at 17:12, <wei.liu2@xxxxxxxxxx> wrote:
> --- a/xen/drivers/passthrough/Makefile
> +++ b/xen/drivers/passthrough/Makefile
> @@ -4,6 +4,8 @@ subdir-$(CONFIG_X86) += x86
>  subdir-$(CONFIG_ARM) += arm
>  
>  obj-y += iommu.o
> -obj-$(CONFIG_X86) += io.o
> +ifeq ($(CONFIG_X86),y)
> +obj-$(CONFIG_HVM) += io.o
> +endif

What to do here depends on whether HVM is to become visible
as a config option on ARM: If it doesn't, no ifeq() or alike is
needed here at all. If it does, I'd favor using consistently the
list approach, i.e.

x86-y := ...
x86-$(CONFIG_HVM) += io.o
obj-$(CONFIG_X86) += $(x86-y)

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel