Re: [Xen-devel] [PATCH] x86/mmcfg/drhd: Move acpi_mmcfg_init() before calling acpi_parse_dmar()

[Zhenzhong Duan <zhenzhong.duan@xxxxxxxxxx>]

On 2018/8/16 17:13, Zhenzhong Duan wrote:
> > > --- a/xen/arch/x86/setup.c
> > > +++ b/xen/arch/x86/setup.c
> > > @@ -1493,6 +1493,10 @@ void __init noreturn __start_xen(unsigned long 
> > > mbi_p)
> > >       generic_apic_probe();
> > > +    pt_pci_init();
> > > +
> > > +    acpi_mmcfg_init();
> > > +
> > >       acpi_boot_init();
> > With the dependency being _in_ acpi_boot_init(), the invocation of
> > acpi_mmcfg_init() should now be moved there.
> Yes, I feel better to move pt_pci_init() and acpi_mmcfg_init() in 
> acpi_boot_init() before acpi_mmcfg_init(). Any more comments?
I see acpi_boot_init() is empty func when CONFIG_ACPI_BOOT isn't set. Do 
we support disabling this config option? If yes, I think above change 
will break non-acpi case.
Thanks
Zhenzhong

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel