[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] qemu-trad: stop using the default IOREQ server



Andrew Cooper writes ("[PATCH] qemu-trad: stop using the default IOREQ server"):
> Paul is OoO for a while, so replying on his behalf.

Thank you.

> Qemu-trad has no support for MMCFG, which is the memory mapped interface
> which supersedes the more legacy cfc/cf8 handling for PCI config space
> accesses.
> 
> Xen's interface passes the requisite information in MMCFG format, which
> is the most efficient way to do it.  This piece of (admittedly messy)
> code converts the information to the legacy interface which is the one
> which Qemu understands.
> 
> tl;dr, It's messy, but it is correct, and is the best (/only, short of
> implementing MMCFG support in qemu-trad) way of doing it.

Thanks for this excelent explanation.  Can you please add it to the
commit message and/or to a comment in the code ?  You may then add my
ack.  I will then commit the patch :-).

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.