Re: [Xen-devel] [PATCH] common/gnttab: Explicitly default to gnttab v1 during domain creation

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.08.18 at 12:31, <andrew.cooper3@xxxxxxxxxx> wrote:
> For reasons which appear to be exclusively down to poor review of the grant
> table v2 code, a grant table's version field was wasn't initialised during
> creation.
> 
> A number of problems (including XSAs) have occurred in the past trying trying
> to use a grant table which hasn't been properly set up, and various areas of
> the code cope with v0 by defaulting to v1.
> 
> In particular, the toolstack using GNTTABOP_setup_table to be able to fill in
> the store/console grants has a side effect of switching to v1.
> 
> In hindsight however, this "fixup if we see 0" is a very poor, with a
> substantial degree of risk.  Explicitly default to grant table v1 during
> domain create, and let the rest of the code work safely in the knowledge that
> the version is sensibly set.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Of course wants to be re-based over Paul's patch, or his over yours,
depending on which one goes in earlier.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel