Re: [Xen-devel] [PATCH v15 12/14] x86/hvm: Drop the use of save functions

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 03.08.18 at 15:53, <aisaila@xxxxxxxxxxxxxxx> wrote:
> @@ -226,15 +225,14 @@ int hvm_save(struct domain *d, hvm_domain_context_t *h)
>      /* Save all available kinds of state */
>      for ( i = 0; i <= HVM_SAVE_CODE_MAX; i++ )
>      {
> -        handler = hvm_sr_handlers[i].save;
> -        save_one_handler = hvm_sr_handlers[i].save_one;
> -        if ( save_one_handler != NULL )
> +        handler = hvm_sr_handlers[i].save_one;
> +        if ( handler != NULL )
>          {
>              for_each_vcpu ( d, v )
>              {
>                  printk(XENLOG_G_INFO "HVM %pv save: %s\n",
>                         v, hvm_sr_handlers[i].name);
> -                rc = save_one_handler(v, h);
> +                rc = handler(v, h);

As already said on v14: You must not invoke the handler once per
vCPU for HVMSR_PER_DOM type records.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel