Re: [Xen-devel] [PATCH v4 30/32] libxl: Re-implement domain_suspend_device_model using libxl__ev_qmp

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Thu, Aug 02, 2018 at 05:38:41PM +0200, Roger Pau Monné wrote:
> On Fri, Jul 27, 2018 at 03:06:12PM +0100, Anthony PERARD wrote:
> > +
> > +    if (qmp_ev_qemu_check_version(ev, 2, 11, 0))
> > +        qmp_parameters_add_bool(gc, &args, "live", dsps->live);
> > +    QMP_PARAMETERS_SPRINTF(&args, "filename", "/dev/fdset/%d", fdset);
> > +    rc = libxl__ev_qmp_send(gc, ev, "xen-save-devices-state", args);
> 
> I think some comments about the logic above would be helpful (at least
> for me). Do you need to pass an extra argument to 2.11.0 and higher
> versions in order to live-migrate?

I'll keep the comment that was there before:
 /* live parameter was added to QEMU 2.11. It signal QEMU that the save
  * operation is for a live migration rather that for taking a snapshot. */

And for more explanation about this parameter, I think I'll let future
archeologist find the commit that introduce its usage.
(db0c7dde021c29c2ae0d847d70fb7b59e02ea522)

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel