Re: [Xen-devel] [PATCH v4 19/32] libxl_qmp: Prepare the command to be sent

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Thu, Aug 02, 2018 at 12:41:26PM +0200, Roger Pau Monné wrote:
> On Fri, Jul 27, 2018 at 03:06:01PM +0100, Anthony PERARD wrote:
> > The actual sent will be done in a separate patch.
> > 
> > Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> > ---
> >  tools/libxl/libxl_internal.h |  4 ++++
> >  tools/libxl/libxl_qmp.c      | 37 ++++++++++++++++++++++++++++++++++++
> >  2 files changed, 41 insertions(+)
> > 
> > diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
> > index 7f200e7a46..110b951bbe 100644
> > --- a/tools/libxl/libxl_internal.h
> > +++ b/tools/libxl/libxl_internal.h
> > @@ -438,6 +438,7 @@ struct libxl__ev_qmp {
> >      libxl__carefd *qmp_cfd;
> >      libxl__ev_fd qmp_efd;
> >      libxl__qmp_state qmp_state;
> > +    unsigned int last_id_used;
> 
> Now there are two last_id_used fields in different structures?
> Shouldn't the previous one be removed when you introduce this new one?

Sorry for the confusion, I'm making modification to the current qmp
engine in order to reuse part that can be reuse in the new, better one.
This is why there's two last_id_used, one for the current
implementation, and one for the new one, libxl__ev_qmp.

Thanks,

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel