Re: [Xen-devel] [PATCH v2 3/5] iommu: make iommu_inclusive_mapping a suboption of dom0-iommu

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Thu, Aug 02, 2018 at 07:58:48AM +0000, Tian, Kevin wrote:
> > +void __hwdom_init arch_iommu_hwdom_init(struct domain *d)
> > +{
> > +    unsigned long i, top, max_pfn;
> > +
> > +    BUG_ON(!is_hardware_domain(d));
> > +
> > +    /* Set the default value of inclusive depending on the hardware. */
> > +    if ( iommu_dom0_inclusive == -1 )
> > +        iommu_dom0_inclusive = boot_cpu_data.x86_vendor ==
> > X86_VENDOR_INTEL;
> > +
> 
> I don't like above style. 
> 
> btw It's better to set it in intel_iommu_hwdom_init.

Then I will also have to set the AMD default in amd_iommu_hwdom_init.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel