[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/4] automation: standardize containerize env names



On Sat, Jul 28, 2018 at 12:11:49PM -0500, Doug Goldstein wrote:
>  # Figure out the base of what we want as our sources
>  # by using the top of the git repo
> -if [[ -n ${WORKDIR} ]]; then
> -    WORKDIR="${WORKDIR}"
> +if [[ -n ${CONTAINER_PATH} ]]; then
> +    :
>  else
> -    WORKDIR=$(git rev-parse --show-toplevel)
> +    CONTAINER_PATH=$(git rev-parse --show-toplevel)

I think you can use -z here and get rid of the empty branch?

The rest looks fine.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.