Re: [Xen-devel] [PATCH v2 2/2] x86/efi: split compiler vs linker support

[Daniel Kiper <daniel.kiper@xxxxxxxxxx>]

On Wed, Jul 18, 2018 at 03:35:20AM -0600, Jan Beulich wrote:
> >>> On 16.07.18 at 16:07, <roger.pau@xxxxxxxxxx> wrote:
> > --- a/xen/arch/x86/Makefile
> > +++ b/xen/arch/x86/Makefile
> > @@ -163,11 +163,12 @@ EFI_LDFLAGS += --minor-image-version=$(XEN_SUBVERSION)
> >  EFI_LDFLAGS += --major-os-version=2 --minor-os-version=0
> >  EFI_LDFLAGS += --major-subsystem-version=2 --minor-subsystem-version=0
> >
> > -# Check if the build system supports PE.
> > -XEN_BUILD_PE := $(shell $(CC) $(filter-out $(CFLAGS-y) .%.d,$(CFLAGS)) -c 
> > efi/check.c -o efi/check.o 2>/dev/null && echo y)
> > -export XEN_BUILD_PE := $(if $(XEN_BUILD_PE),$(shell $(LD) -mi386pep 
> > --subsystem=10 -o efi/check.efi efi/check.o 2>/dev/null && echo y))
> > -ifeq ($(XEN_BUILD_PE),y)
> > -CFLAGS += -DXEN_BUILD_PE
> > +# Check if the compiler supports the MS ABI.
> > +export XEN_BUILD_EFI := $(shell $(CC) $(filter-out $(CFLAGS-y) 
> > .%.d,$(CFLAGS)) -c efi/check.c -o efi/check.o 2>/dev/null && echo y)
> > +# Check if the linker supports PE.
> > +XEN_BUILD_PE := $(if $(XEN_BUILD_EFI),$(shell $(LD) -mi386pep 
> > --subsystem=10 -o efi/check.efi efi/check.o 2>/dev/null && echo y))
> > +ifeq ($(XEN_BUILD_EFI),y)
> > +CFLAGS += -DXEN_BUILD_EFI
> >  endif
>
> With this suitably re-based according to the changes requested to
> patch 1:
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Patches LGTM +/- Jan comments. Though I would like to test the
final version just to be sure. So, Roger, may I ask you to post
the patches which takes into account Jan's comments?

Daniel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel