Re: [Xen-devel] [PATCH] x86: report use of PCID together with reporting XPTI status

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.07.18 at 22:52, <cardoe@xxxxxxxxxx> wrote:
> On Mon, Jul 16, 2018 at 10:45:15AM -0600, Jan Beulich wrote:
>> --- a/xen/arch/x86/spec_ctrl.c
>> +++ b/xen/arch/x86/spec_ctrl.c
>> @@ -256,9 +256,10 @@ static void __init print_details(enum in
>>             boot_cpu_has(X86_FEATURE_SC_RSB_HVM)      ? " RSB"           : 
>> "",
>>             opt_eager_fpu                             ? " EAGER_FPU"     : 
>> "");
>>  
>> -    printk("  XPTI (64-bit PV only): Dom0 %s, DomU %s\n",
>> +    printk("  XPTI (64-bit PV only): Dom0 %s, DomU %s (with%s PCID)\n",
> 
> Do you ever foresee wanting to add another flag in here? It might be
> better to just have "with: %s" and do xpti_pcid_enabled ? "PCID" : "" if
> you do. If not then this seems like a good addition to me and is
> definitely welcome to folks wanting to know if they're using PCID.

I don't foresee additions here. Re-arranging this can be done if and
when such an addition becomes necessary.

> Reviewed-by: Doug Goldstein <cardoe@xxxxxxxxxx>

Thanks, Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel