Re: [Xen-devel] [PATCH] x86: report use of PCID together with reporting XPTI status

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.07.18 at 13:05, <roger.pau@xxxxxxxxxx> wrote:
> On Mon, Jul 16, 2018 at 10:45:15AM -0600, Jan Beulich wrote:
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> 
>> --- a/xen/arch/x86/pv/domain.c
>> +++ b/xen/arch/x86/pv/domain.c
>> @@ -288,6 +288,12 @@ int pv_domain_initialise(struct domain *
>>      return rc;
>>  }
>>  
>> +bool __init xpti_pcid_enabled(void)
>> +{
>> +    return use_invpcid && cpu_has_pcid &&
>> +           (opt_pcid == PCID_ALL || opt_pcid == PCID_XPTI);
>> +}
>> +
>>  static void _toggle_guest_pt(struct vcpu *v)
>>  {
>>      const struct domain *d = v->domain;
>> --- a/xen/arch/x86/spec_ctrl.c
>> +++ b/xen/arch/x86/spec_ctrl.c
>> @@ -256,9 +256,10 @@ static void __init print_details(enum in
>>             boot_cpu_has(X86_FEATURE_SC_RSB_HVM)      ? " RSB"           : 
>> "",
>>             opt_eager_fpu                             ? " EAGER_FPU"     : 
>> "");
>>  
>> -    printk("  XPTI (64-bit PV only): Dom0 %s, DomU %s\n",
>> +    printk("  XPTI (64-bit PV only): Dom0 %s, DomU %s (with%s PCID)\n",
>>             opt_xpti & OPT_XPTI_DOM0 ? "enabled" : "disabled",
>> -           opt_xpti & OPT_XPTI_DOMU ? "enabled" : "disabled");
>> +           opt_xpti & OPT_XPTI_DOMU ? "enabled" : "disabled",
>> +           xpti_pcid_enabled() ? "" : "out");
>>  }
> 
> Maybe you could place xpti_pcid_enabled in spec_ctrl.c, or just open
> code it (possibly with a bool) in print_details?

I very definitely want it to sit next to pv_domain_initialise(), so that
the similar logic can be easily seen and compared.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel