Re: [Xen-devel] [PATCH v2] tools: remove local links to the x86 headers

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Fri, Jul 13, 2018 at 04:04:56AM -0600, Jan Beulich wrote:
> >>> On 13.07.18 at 09:55, <roger.pau@xxxxxxxxxx> wrote:
> > On Fri, Jul 13, 2018 at 01:49:37AM -0600, Jan Beulich wrote:
> >> >>> On 12.07.18 at 18:48, <roger.pau@xxxxxxxxxx> wrote:
> >> > In the x86 test harness and the fuzzer, and instead create a link in
> >> > the tools/include directory that can be used by all the tools.
> >> > 
> >> > No functional change.
> >> > 
> >> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> >> > ---
> >> > Cc: Jan Beulich <jbeulich@xxxxxxxx>
> >> > Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> >> > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> >> > Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> >> > ---
> >> > Changes since v1:
> >> >  - Don't remove the header dependencies in the makefile for the x86
> >> >    emulator test harness.
> >> 
> >> Hmm, afaics you've done the same for the fuzzer where afaict it's
> >> unnecessary. Any specific reason?
> > 
> > The fuzzer also includes x86-emulate.h which depends on those headers,
> > so it should also be rebuilt.
> 
> See my original mail - afaict the fuzzer makes use of .*.d files, so
> explicit recodring of dependencies should not be needed.

I'm afraid that doesn't seem to work. If I modify any of the headers
without the explicit makefile tracking a rebuild is not triggered.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel