Re: [Xen-devel] [PATCH v2 01/13] grant_table: use term 'mfn' for machine frame numbers...

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: George Dunlap [mailto:george.dunlap@xxxxxxxxxx]
> Sent: 10 July 2018 14:20
> To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>; George Dunlap
> <George.Dunlap@xxxxxxxxxx>; Ian Jackson <Ian.Jackson@xxxxxxxxxx>; Jan
> Beulich <jbeulich@xxxxxxxx>; Julien Grall <julien.grall@xxxxxxx>; Konrad
> Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>; Stefano Stabellini
> <sstabellini@xxxxxxxxxx>; Tim (Xen.org) <tim@xxxxxxx>; Wei Liu
> <wei.liu2@xxxxxxxxxx>
> Subject: Re: [PATCH v2 01/13] grant_table: use term 'mfn' for machine frame
> numbers...
> 
> On 07/07/2018 12:05 PM, Paul Durrant wrote:
> > ...rather than more ambiguous term 'frame'.
> >
> > There are many places in the grant table code that use a variable or
> > field name '.*frame' to refer to a quantity that is strictly an MFN, and
> > even has type mfn_t.
> > This patch is a purely cosmetic patch that substitutes 'frame' with 'mfn'
> > in those places to make the purpose of the variable or field name more
> > obvious.
> >
> > Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> 
> Looks good.  One minor comment...
> 
> > @@ -2320,7 +2320,7 @@ release_grant_for_copy(
> >      struct grant_table *rgt = rd->grant_table;
> >      grant_entry_header_t *sha;
> >      struct active_grant_entry *act;
> > -    mfn_t r_frame;
> > +    mfn_t mfn;
> >      uint16_t *status;
> >      grant_ref_t trans_gref;
> >      struct domain *td;
> 
> If you end up respinning this, you might consider making this 'rmfn' or
> somethign, just because everything in this function seems to have the
> 'r' prefix.
>

I looked again and TBH I'd prefer to just stick with mfn.
 
> But either way:
> 
> Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx>

Thanks,

  Paul
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel