Re: [Xen-devel] [PATCH v2] x86: consolidate legacy FPU state loading

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 05.07.18 at 19:19, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 05/07/18 14:54, Jan Beulich wrote:
>> --- a/xen/arch/x86/i387.c
>> +++ b/xen/arch/x86/i387.c
>> @@ -337,6 +337,49 @@ int vcpu_init_fpu(struct vcpu *v)
>>      return rc;
>>  }
>>  
>> +void vcpu_load_fpu(struct vcpu *v, struct xsave_struct *xsave_area,
> 
> How about vcpu_setup_fpu() ? This function either initialises the FPU
> state to suitable defaults, or copies in state provided by a hypercall.
> 
> The name "load" is too easily associated with save/restore IMO.

I didn't think it would be, but I'm not really against using "setup" instead.

> Otherwise, Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Thanks, Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel