Re: [Xen-devel] [PATCH] x86: consolidate legacy FPU state loading

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 03.07.18 at 12:48, <wei.liu2@xxxxxxxxxx> wrote:
> On Tue, Jun 26, 2018 at 01:51:47AM -0600, Jan Beulich wrote:
>> First of all introduce a helper function instead of replicating almost
>> the same code for PV and HVM. The differences between the two pieces of
>> code actually points out an issue (which is also addressed here): In
>> the HVM case FCW would not have been set to FCW_RESET in certain cases
>> (note for example that XRSTOR loads FCW_DEFAULT rather then FCW_RESET
>> when the respective xstate_bv bit is clear).
>> 
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> 
> I do wonder if this function can be used in hvm_vcpu_reset_state as
> well.

Oh, indeed - this didn't even occur to me.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel