[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] schedulers: validate / correct global data just once

On Fri, 2018-06-29 at 07:10 -0600, Jan Beulich wrote:
> Also mark command line parsing routine __init.
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Dario Faggioli <dfaggioli@xxxxxxxx>

In fact...

> For credit2 I'm not sure the relatively verbose logging of all
> parameters should really happen upon every initialization. Otoh
> emitting
> it at boot time when the scheduler isn't actually used may also be
> confusing.
... I think it is ok to have these messages printed just once, during
boot, for all the schedulers we support (and that have been compiled

The info about some parameters having been adjusted, although not
printed every time a scheduler instance is created, will always be
available in logs/xl dmesg, if one needs it.

About the confusion, perhaps adding a printk(), in each global_init
hook, saying something like "Credit Scheduler: global parameter
initialization" (and the same for Credit2, etc) would help.

My rev-by tag stands if that is added in this patch (and even if a
different wording is used). But I am also fine with the patch to go in
without that, as I consider it an improvement of the current situation

<<This happens because I choose it to happen!>> (Raistlin Majere)
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Software Engineer @ SUSE https://www.suse.com/

Attachment: signature.asc
Description: This is a digitally signed message part

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.